Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhaul project, update to current standards #8

Merged
merged 2 commits into from
Mar 19, 2019
Merged

Overhaul project, update to current standards #8

merged 2 commits into from
Mar 19, 2019

Conversation

BendingBender
Copy link
Contributor

I know this PR contains a whole lot of changes and I didn't ask you whether you want all these changes at all. If you say that you won't accept it, it's OK for me, I will publish a new package on NPM. Nevertheless, I still wanted to try.

Changes in this PR:

  • sync with current version of TraceKit
  • introduce ESLint + Prettier + EditorConfig
  • introduce builds for CJS/ESM/Browser
  • port to ES6+
  • remove grunt, use npm scripts instead

@BendingBender
Overhaul project, update to modern standards:
9fffc11 
- sync with current version of TraceKit
- introduce ESLint + Prettier + EditorConfig
- introduce builds for CJS/ESM/Browser
- port to ES6+
- remove grunt, use npm scripts instead
Calamari
Calamari reviewed Feb 7, 2019
View reviewed changes
.vscode/launch.json Outdated Show resolved Hide resolved
Calamari
Calamari approved these changes Feb 7, 2019
View reviewed changes
Copy link
Contributor

@Calamari Calamari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I really like the change. I never got to it, since it works fine for our needs. So, thank you. I will happily merge it in and bring out a version 0.2, hopefully later today :)

Calamari
Calamari reviewed Feb 7, 2019
View reviewed changes
README.md Show resolved Hide resolved
@BendingBender
Copy link
Contributor Author

@Calamari Any updates on this?

Calamari
Calamari approved these changes Mar 19, 2019
View reviewed changes
Copy link
Contributor

@Calamari Calamari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry, it took so long. I really thought I did already merge this, but I guess it was only in my mind. :)

Thanks for the work.

@Calamari Calamari merged commit 44088bd into errwischt:master Mar 19, 2019
@Calamari
Copy link
Contributor

I will further do some testing and release a new version later today.

@BendingBender BendingBender deleted the overhaul-project branch March 19, 2019 10:28
@BendingBender
Copy link
Contributor Author

BendingBender commented Mar 19, 2019 •
edited
Loading

Any objections if I would contribute a type definition file for TypeScript?

@Calamari
Copy link
Contributor

Not at all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calamari Calamari Calamari approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BendingBender @Calamari